Add error messages for contradicting flags#330
Add error messages for contradicting flags#330betasve wants to merge 2 commits intohyperledger:mainfrom
Conversation
Signed-off-by: Svetoslav Blyahov <svetoslav.blyahov@toptal.com>
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
A few typos and would recommend adding a test
cmd/init.go
Outdated
|
|
||
| func validateRemoteNodeVsBlockChainNodeFlags(remoteNodeUrl, blockchainNodePorvider string) error { | ||
| if len(remoteNodeUrl) != 0 && blockchainNodePorvider != "geth" { | ||
| return errors.New("`remote-noted-url` and `blockchain-node` can't both be specified") |
There was a problem hiding this comment.
| return errors.New("`remote-noted-url` and `blockchain-node` can't both be specified") | |
| return errors.New("Both flags `remote-node-url` and `blockchain-node` can't be specified") |
There was a problem hiding this comment.
hi @EnriqueL8, thanks for your review. I will correct the text and look for a place where to place the test.
There was a problem hiding this comment.
hi @EnriqueL8, now that I took a deeper look, I remembered why I didn't provide tests initially. I didn't find any of the initCommon behavior to have been tested. Can you please let me know if I'm mistaken, or if not - and still a test needs to be written for this part - where, according to the practices of this repo, shall it be?
Thanks in advance for your help.
There was a problem hiding this comment.
okay this might be more significant work to establish a test framework for these
|
@betasve can you fix the DCO check here please |
2 participants
Aims to fix the issue mentioned here #290